Skip to content

disable autocompletion on login form#39955

Open
taoufiqaitali wants to merge 1 commit intomagento:2.4-developfrom
taoufiqaitali:patch-6
Open

disable autocompletion on login form#39955
taoufiqaitali wants to merge 1 commit intomagento:2.4-developfrom
taoufiqaitali:patch-6

Conversation

@taoufiqaitali
Copy link
Member

@taoufiqaitali taoufiqaitali commented Jun 3, 2025 •
edited
Loading

Description (*)

The form in authentication-popup.html uses autocompletion, which allows some browsers to retain sensitive information in their history.Autocompletion of forms allows some browsers to retain sensitive information in their history.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@taoufiqaitali
disable autocompletion on login form
5908563 
The form in authentication-popup.html uses autocompletion, which allows some browsers to retain sensitive information in their history.Autocompletion of forms allows some browsers to retain sensitive information in their history.
@m2-assistant
Copy link

m2-assistant bot commented Jun 3, 2025

Hi @taoufiqaitali. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jun 3, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review

Projects

Pull Requests Dashboard
Status: Pending Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@taoufiqaitali @engcom-Bravo

Comments